&phoeenniixx [BUG] change progress bar default to simple and decouple rich core dependency to avoid default failure#601
Conversation
fkiraly
changed the title
simple and remove rich core dependency to avoid default failuresimple and decouple rich core dependency to avoid default failure
fkiraly
changed the title
simple and decouple rich core dependency to avoid default failuresimple and decouple rich core dependency to avoid default failure
phoeenniixx
left a comment
phoeenniixx
left a comment
There was a problem hiding this comment.
This is working! But I was thinking we should not completely remove rich from progess_bar? We could "supress" it and add it to soft-dep for people who are already using it?
I was also thinking that, but I think the problem is that there must be some version from which compatibility with The same is true for users who explicitly set Hence I think - at least until we understand why |
|
We can open an issue though to track this, see #605 |
2 participants
changes progress bar default to
simpleand removerichcore dependency in the model progress bar.Fixes #600, acting on the suspicion of @phoeenniixx that the
richbased progress bar is the culprit.No deprecation is needed for the change in default, since progress bars are purely visual, and the
richbased one is replaced by on-board python stdout.